fix: detect addressbook ACL's properly#4728
Merged
SebastianKrupinski merged 1 commit intomainfrom Sep 24, 2025
Merged
Conversation
SebastianKrupinski
requested review from
GVodyanov and
hamza221
as code owners
This was referenced Sep 22, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4728 +/- ##
============================================
- Coverage 10.76% 10.75% -0.02%
Complexity 291 291
============================================
Files 128 128
Lines 6512 6520 +8
Branches 1191 1195 +4
============================================
Hits 701 701
- Misses 5690 5697 +7
- Partials 121 122 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ChristophWurst
approved these changes
Sep 24, 2025
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Looks good!
Two small nag comments:
- make this a
fixcommit. You are not adding a feature. you are fixing the handling of ACLs - relabel the commit message accordingly. the fix is not specific to recently contacted but any addressbook with fine-granular ACLs
This should be backported, as a fix
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
SebastianKrupinski
force-pushed
the
fix/issue-55169-delete-recent-contact
branch
from
e250829 to
a4a0a2f
Compare
SebastianKrupinski
changed the title
Contributor
Author
|
/backport to stable8.0 |
Contributor
Author
Done |
Contributor
Author
|
/backport to stable7.3 |
SebastianKrupinski
deleted the
fix/issue-55169-delete-recent-contact
branch
github-project-automation
bot
moved this from 🏗️ In progress
to ☑️ Done
in 💌 📅 👥 Groupware team
This was referenced Sep 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Required for #nextcloud/server#55169